Coordinates by maksumi · Pull Request #349 · javascript-tutorial/es.javascript.info · GitHub
Skip to content

Coordinates#349

Merged
EzequielCaste merged 71 commits intojavascript-tutorial:masterfrom
maksumi:coordinates
Aug 31, 2020
Merged

Coordinates#349
EzequielCaste merged 71 commits intojavascript-tutorial:masterfrom
maksumi:coordinates

Conversation

@maksumi
Copy link
Copy Markdown
Collaborator

@maksumi maksumi commented Aug 14, 2020

No description provided.

Maksumi Murakami and others added 16 commits July 21, 2020 00:42
Merge pull request #3 from javascript-tutorial/master
b5e3cc5 
Update
Merge pull request #4 from javascript-tutorial/master
53e75b5 
Update
Merge pull request #5 from javascript-tutorial/master
d5ea01b 
Update
Merge pull request #6 from javascript-tutorial/master
cde00e0 
Update
Merge pull request #7 from javascript-tutorial/master
81e9cfd 
Update
@vplentinax @joaquinelio
Update (#8)
5402692 
* atrrdom

* scrolling

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update article.md

* Update 2-ui/1-document/06-dom-attributes-and-properties/1-get-user-attribute/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Co-authored-by: vplentinax <jc.lerebours.vp@hotmail.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Merge pull request #9 from javascript-tutorial/master
16ccddf 
Update
Update (#10)
707db67
Update (#11)
5d7a154
Merge pull request #13 from javascript-tutorial/master
8c26be9 
Update
Merge pull request #14 from javascript-tutorial/master
371af05 
Update
Merge pull request #15 from javascript-tutorial/master
281ce34 
Update
Merge pull request #16 from javascript-tutorial/master
9328be8 
Update
Merge pull request #17 from javascript-tutorial/master
8210b40 
Update
Merge pull request #18 from javascript-tutorial/master
9c9f628 
Update
Add files via upload
c2728b4
@iliakan iliakan mentioned this pull request Aug 14, 2020
Open
joaquinelio
joaquinelio requested changes Aug 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO TERMINÉ la revision, me voy a comer. Me falta ARTICLE.

Ademas creo que me agarro un stroke, veo cosas de ciencia ficción...

Ah, "--"
Te comento que el guion largo español sí esta permitido en listas, y se ve más fácil, yo lo dejo.
Lo que no usamos es el guion largo disruptivo.
Lo habia comentado en glosario

Tambien:
los que inventaron Lorem ipsum lo hicieron para que el texto no distrajera de lo que se estaba mostrando...
Y me quede leyendo la novela. Es larga, ¿habra suficientes ejercicios?

Comment thread 2-ui/1-document/11-coordinates/1-find-point-coordinates/solution.md Outdated
Comment thread 2-ui/1-document/11-coordinates/2-position-at/solution.view/index.html Outdated
Comment thread 2-ui/1-document/11-coordinates/2-position-at/solution.view/index.html Outdated
Comment thread 2-ui/1-document/11-coordinates/2-position-at/task.md
Comment thread 2-ui/1-document/11-coordinates/3-position-at-absolute/solution.md Outdated
Comment thread 2-ui/1-document/11-coordinates/3-position-at-absolute/solution.md Outdated
Comment thread 2-ui/1-document/11-coordinates/3-position-at-absolute/solution.view/index.html
Comment thread 2-ui/1-document/11-coordinates/3-position-at-absolute/task.md Outdated
Comment thread 2-ui/1-document/11-coordinates/4-position-inside-absolute/task.md Outdated
Comment thread 2-ui/1-document/11-coordinates/4-position-inside-absolute/task.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Aug 14, 2020

Maksumi Murakami and others added 3 commits August 14, 2020 22:37
@joaquinelio
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
daa4e2e 
…on.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@joaquinelio
Apply suggestions from code review
18c86b5 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Update task.md
2d26388
@maksumi
Copy link
Copy Markdown
Collaborator Author

maksumi commented Aug 15, 2020

/done

vplentinax and others added 2 commits August 31, 2020 13:12
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
1bc20bd 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
861b2e9 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio
Copy link
Copy Markdown
Member

joaquinelio commented Aug 31, 2020

BUUUUUUU
Bueno, ahora son dos los autoritarios.
Para qué hay un procedimiento, para eso nunca esperamos al traductor y se lo modificamos todo.

Ahora estoy reviendo... Get Smart, en inglés, me encanta.
cuento porque Maksumi es del país del doblaje, sabe escribir y sabe traducir, y siempre fue criterioso.

vplentinax and others added 6 commits August 31, 2020 13:14
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
1141d1c 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
454ac36 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
de345d5 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
4c9f381 
….view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
dc59ce6 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
1a823bb 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax
Copy link
Copy Markdown
Contributor

vplentinax commented Aug 31, 2020

BUUUUUUU
Bueno, ahora son dos los autoritarios.
Para qué hay un procedimiento, para eso nunca esperamos al traductor y se lo modificamos todo.

Ahora estoy reviendo... Get Smart, en inglés, me encanta.
cuento porque Maksumi es del país del doblaje, sabe escribir y sabe traducir, y siempre fue criterioso.

Yo estoy aceptando los commits porque @maksumi nos paso el mando de su artículo.

vplentinax and others added 9 commits August 31, 2020 13:23
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
2015eae 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
f15a998 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
ac0230b 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
ab22501 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
c1a5d4e 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
dc115cc 
…tion.view/index.html

Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/task.md
082548e 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/article.md
49a83d5 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 2-ui/1-document/11-coordinates/article.md
3ac35a1 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@vplentinax
Copy link
Copy Markdown
Contributor

vplentinax commented Aug 31, 2020

/done

@EzequielCaste EzequielCaste merged commit 0e5dcff into javascript-tutorial:master Aug 31, 2020
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Aug 31, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Copy Markdown
Member

joaquinelio commented Aug 31, 2020 •
edited
Loading

@vplentinax

Yo estoy aceptando los commits porque @maksumi nos paso el mando de su artículo.

Así pos sí...

Era solo una task...
Lástima, era una obra de arte.

@maksumi
Copy link
Copy Markdown
Collaborator Author

maksumi commented Sep 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplentinax vplentinax vplentinax left review comments

@joaquinelio joaquinelio joaquinelio approved these changes

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maksumi @javascript-translate-bot @EzequielCaste @joaquinelio @vplentinax