{{ message }}
Open
Conversation
Contributor
Author
fzakaria
commented
Oct 27, 2025
| project(jtjson) | ||
| project(jtjson | ||
| LANGUAGES CXX | ||
| VERSION 0.1.0 |
Contributor
Author
There was a problem hiding this comment.
I picked a version -- you might want to look this over.
| libdir=@PKG_CONFIG_LIBDIR@ | ||
| includedir=@PKG_CONFIG_INCLUDEDIR@ | ||
|
|
||
| Name: json.cpp |
Contributor
Author
There was a problem hiding this comment.
This is what it is named in nixpkgs but I see the project is now named jtjson.
Not sure what you would like to pick; I'm not sure if nixpkgs has a mandate that it has to be named after the repo name.
The .a and .so are also libjson so I thought maybe json.cpp was "better"
There was a problem hiding this comment.
Yeah we're happy to rename a package that just got added days ago in Nixpkgs, I would think.
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure you don't expose double-conversion
Ericson2314
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #17
Validation
I ran this patch in nixpkgs
And the test worked for validating the pkg-config.