{{ message }}
Repository navigation
Conversation
Local servers like mlx_lm and LM Studio don't need a key. Anthropic- compatible providers still require one, and the base URL is still validated. Fixes janhq#8740
jamesdam
added a commit
that referenced
this pull request
Sep 15, 2026
48071fb parameterized the NSIS template's absolute paths behind a `jan_workspace` placeholder and taught the internal Windows workflow to substitute it. The external (fork PR) workflow was never given the same line, so it feeds NSIS a template with 12 unexpanded placeholders: !define INSTALLERICON "jan_workspace\src-tauri\icons\icon.ico" Error while loading icon from "jan_workspace\src-tauri\icons\icon.ico": can't open file Error in script "...\nsis\x64\installer.nsi" on line 279 -- aborting creation process failed to bundle project: `The system cannot find the file specified.` Every fork PR has failed build-windows-x64-external since 2026-09-04 as a result; confirmed on two unrelated PRs (#8942, #8944) with byte-identical output. The ~18 preceding `SignTool Error: No signature found` lines are unrelated noise from signing unsigned NSIS plugin DLLs -- they are also present on green internal runs. The added lines are byte-identical to the internal workflow's, so the two now agree. Every placeholder the template uses is substituted by both.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
You can add a custom OpenAI-compatible provider without an API key. That's the normal setup for local servers like mlx_lm and LM Studio.
Anthropic-compatible providers still require a key, and the base URL still has to be a valid http(s) URL.
Refreshing models on a custom OpenAI-compatible provider also works with an empty key. Built-in remotes (OpenAI, etc.) still need one.
Fixes Issues
Self Checklist