{{ message }}
Upgrade Java 17 to Java 21 LTS with MVP Test Coverage#15
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Upgrade Java 17 to Java 21 LTS with MVP Test Coverage#15devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Update Maven compiler plugin to Java 21 (source and target) - Add maven-compiler-plugin version 3.11.0 - Add maven-surefire-plugin 3.1.2 for JUnit 5 support - Add JUnit Jupiter 5.10.0 and Mockito 5.5.0 test dependencies - Create test infrastructure (src/test/java and src/test/resources) - Add ApplicationTest with tests for renderError, OAuth callback error handling - Add SettingsTest with tests for populate, getBasicAuthHeader, updateTokenInfo Note: maven-shade-plugin kept at 3.6.0 (version 4.0.0 does not exist in Maven Central) Co-Authored-By: Jack <jack.l.killian@gmail.com>
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the application from Java 17 to Java 21 LTS and adds MVP test coverage. The project previously had no test files.
Changes:
ApplicationTest.javawith 4 tests coveringrenderError(), OAuth callback error handling, and index renderingSettingsTest.javawith 9 tests covering token management, configuration, and helper methodsNote: The task requested upgrading maven-shade-plugin to 4.0.0, but that version does not exist in Maven Central. The plugin remains at 3.6.0, which is compatible with Java 21.
Local Testing
The application was tested locally with Java 21.0.9 and runs successfully on port 9090:
Review & Testing Checklist for Human
.github/workflows/maven.ymlstill uses JDK 17.0.5+8. CI will fail until this is updated to Java 21. This was not in scope but is required for the PR to pass CI.ApplicationTest.java(lines 42-48, 62-63, 78-79) - this accesses private methods which is acceptable for MVP but may be fragilemvn clean packagelocally with Java 21 to verify the fat JAR builds correctlyjava -jar target/oauth2-example-1.0.jaron port 9090Notes
Link to Devin run: https://app.devin.ai/sessions/5db90e70586c42dfa91812408167bbcf
Requested by: @jack-killian