{{ message }}
Add unit tests for error handling and authorization checks#13
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Add unit tests for error handling and authorization checks#13devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add JUnit 5 and Mockito test dependencies to pom.xml - Add maven-surefire-plugin for JUnit 5 support - Add LoggingInterceptorTest for error handling scenarios (404, 401, 403, 500, 502, 503) - Add RequestExceptionTest for exception message formatting - Add AuthorizationTest for authorization scenarios: - Private transaction access tests - Token authorization tests (expired, invalid, missing) - Organization access tests - Insufficient permissions tests (read-only, delete) Co-Authored-By: Jack <jack.l.killian@gmail.com>
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit test coverage for error handling and authorization scenarios that were previously missing from the Deere API tests. The existing tests only covered basic happy path scenarios.
Changes:
pom.xmlmaven-surefire-pluginfor JUnit 5 supportLoggingInterceptorTest- tests error handling for HTTP status codes (404, 401, 403, 500, 502, 503)RequestExceptionTest- tests exception message formatting for various error responsesAuthorizationTest- tests authorization scenarios including:All 27 tests pass locally.
Review & Testing Checklist for Human
LoggingInterceptorthrowsRequestExceptionwith correct status codes, but don't test actual API integrationTest plan: Run
mvn testto verify all 27 tests pass.Notes
These tests mock HTTP responses to verify the error handling behavior of
LoggingInterceptorandRequestException. For true end-to-end authorization testing, integration tests against the actual API would be needed.Link to Devin run: https://app.devin.ai/sessions/db20770b875248af97537fe3052ebb86
Requested by: @jack-killian