{{ message }}
Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FileDescriptor+ global list design goes back to the original file operations from 2005. uSTL was introduced in 2011. That conversion replaced the oldPointListwith anustl::list, but kept the original data model.The new filesystem made
FileDescriptora larger object in 2012. When the old filesystem was restored in 2015, the simple object containing only an fd and aFile*came back. The filesystem cleanup in 2021 wrapped the global list inFileDescriptorList, but otherwise kept this design.Today this is just a mapping from numeric fds to open files. With this PR I would replace the separately allocated pair-like objects and the list with an
ustl::map<uint32, KernelFileHandle*>.Also, to fix #175, I would rename
FiletoKernelFileHandleto make the distinction between the numeric fd exposed to userspace and the corresponding kernel object clearer.