Benchmark section removed from README by themisir · Pull Request #899 · isar/hive · GitHub
Skip to content

Benchmark section removed from README - #899

Open
themisir wants to merge 1 commit into
mainfrom
themisir/remove-benchmark
Open

themisir wants to merge 1 commit into
mainfrom
themisir/remove-benchmark

Conversation

@themisir

@themisir themisir commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@PawlikMichal25

Copy link
Copy Markdown

@themisir

Copy link
Copy Markdown
Contributor Author

@themisir Why are you considering removing the benchmark?

It does not reflect current state of the ecosystem. The benchmarks were old and a lot changed since then. Also some points might be "unfair" to compare on benchmark basis. So I don't want people to make decision based on misleading data.

Also some benchmark steps were not tested correctly back then or for some other reasons when I do benchmark myself the results are different, for some reason Lazy boxes performed worst than regular boxes.

@PawlikMichal25

Copy link
Copy Markdown

It's a fair point that we should keep the benchmark up to date.
I think it's normal for benchmarks that they compare a certain thing though. So it's developer's responsibility to think whether a certain benchmark relates to their use case.

I'm not sure how it's right now, but I actually adjusted and ran the benchmark myself for my article. The results were somewhat different, but the conclusion was the same - Hive is fast.

Perhaps the benchmark should be updated or described differently, but I think it's responsible to include some benchmark, if we're claiming that Hive is "blazing fast" in documentation.

PS: I'm just a random guy from internet, so sorry for "sticking my nose" here, but I always liked Hive and considered speed to be one of it's most important benefits :)

@themisir

themisir commented Mar 27, 2022 •

Copy link
Copy Markdown
Contributor Author

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants