{{ message }}
Add image test using nbval and nbdime#32
Merged
martinRenou merged 5 commits intoipython:mainfrom Jun 5, 2024
Merged
Conversation
ianthomas23
force-pushed
the
add_test
branch
3 times, most recently
from
3b5cb7d to
73422c2
Compare
Collaborator
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to the project to confirm that the inline backend is used even if not specified using the
%matplotlibmagic and that images are correctly produced. It uses a single notebook for this, andnbvalandnbdimeto do the actual testing so the additions here are minimal. Essentiallynbvalruns the notebook and checks that the output cells are the same as those contained within the test notebook but ignores images.nbdimeadds image comparison. Text is excluded from the plots, as usually occurs in Matplotlib tests, as text rendering can vary slightly on different platforms.The original test to confirm the import works are now in a new file
test_import.py.I have also changed the installation of dependencies to just use PyPI rather than
mambaas this should be simpler and faster, but I can switch this back if preferred.