Quote packaging magic command arguments by lin-hongkuan · Pull Request #15268 · ipython/ipython · GitHub
Skip to content

Quote packaging magic command arguments#15268

Draft
lin-hongkuan wants to merge 2 commits into
ipython:mainfrom
lin-hongkuan:codex/quote-packaging-magics
Draft

Quote packaging magic command arguments#15268
lin-hongkuan wants to merge 2 commits into
ipython:mainfrom
lin-hongkuan:codex/quote-packaging-magics

Conversation

@lin-hongkuan

@lin-hongkuan lin-hongkuan commented Jun 24, 2026

Copy link
Copy Markdown

Summary

  • add platform-specific shell argument joining for packaging magics
  • quote %conda/%mamba/%micromamba command paths, injected prefixes, and parsed arguments so paths with spaces survive shell execution
  • reuse the same quoting helper for %pip and %uv interpreter paths

Fixes #12896.

@Carreau Carreau added this to the 9.15 milestone Jun 25, 2026
@Carreau Carreau removed this from the 9.15 milestone Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list2cmdline is supposed to be internal cpython and marked as not public, this should have either an expalnation; or be exlicitely marked as such.

@Carreau

Carreau commented Jun 26, 2026

Copy link
Copy Markdown
Member

@Carreau Carreau marked this pull request as draft June 26, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in magic commands do not escape spaces in path

2 participants