{{ message }}
Narrow bare except: clauses in oinspect and interactiveshell#15252
Merged
Conversation
oinspect._getdef: bare except → except Exception so KeyboardInterrupt and SystemExit are no longer silently swallowed during signature rendering. interactiveshell.safe_execfile / safe_execfile_ipy: bare except on file-open probes → except OSError, which is the only exception that opening a file can legitimately raise. Prevents masking programmer errors and control-flow exceptions. https://claude.ai/code/session_01VPnGTgifZ8HMAfiqEVftjj
Carreau
force-pushed
the
claude/focused-goldberg-gLkt6
branch
from
571bce6 to
6ec2540
Compare
Carreau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow bare
except:clauses so control-flow exceptions are no longer silently swallowed.except:→except ExceptionsoKeyboardInterruptandSystemExitare no longer swallowed during signature rendering.except:on file-open probes →except OSError, which is the only exception that opening a file can legitimately raise. Prevents masking programmer errors and control-flow exceptions.Cherry-picked from #15237. Rebased on current
main.