feat(ionNavBar,ionHeaderBar): use declarative syntax by ajoslin · Pull Request #788 · ionic-team/ionic-framework · GitHub
Skip to content

feat(ionNavBar,ionHeaderBar): use declarative syntax - #788

Closed
ajoslin wants to merge 1 commit into
masterfrom
navbar-declarative
Closed

feat(ionNavBar,ionHeaderBar): use declarative syntax#788
ajoslin wants to merge 1 commit into
masterfrom
navbar-declarative

Conversation

@ajoslin

@ajoslin ajoslin commented Mar 14, 2014

Copy link
Copy Markdown
Contributor

Closes #777
Closes #596
Closes #477

New Documentation:

Also: test count up to 324 :-)

BREAKING CHANGE:

navBar is majorly different.  Manually write this when changelog is
released.  Add link to docs.
@ajoslin

ajoslin commented Mar 14, 2014

Copy link
Copy Markdown
Contributor Author

@ajoslin

ajoslin commented Mar 14, 2014

Copy link
Copy Markdown
Contributor Author

Landed via bfcfae3

@ajoslin ajoslin closed this Mar 14, 2014
@rvanbaalen

Copy link
Copy Markdown

@ajoslin Ok, nice.. but this is quite the breaking change you introduced here. Any comments on how to transition from the old code to this?

For example, I now have $scope.leftButtons defined in my controllers to generate left buttons in my header. But that doesn't seem to work anymore?

@ajoslin

ajoslin commented Mar 15, 2014

Copy link
Copy Markdown
Contributor Author

@ajoslin
ajoslin deleted the navbar-declarative branch April 16, 2014 13:42
ShaneK added a commit that referenced this pull request Apr 28, 2026
Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
`@stencil/react-output-target` is pinned to exactly `1.5.0` in
`core/package.json` and `packages/react/package.json`. This was a
defensive pin after `1.5.1` shipped a regression that dropped the
`Partial<C>` wrapper from `StencilProps`, which broke everything in our
react apps by [requiring all props to be
defined](https://github.com/ionic-team/ionic-framework/actions/runs/25007199736/job/73233599812?pr=30831).
Exact-pinning meant we couldn't pick up future patches in the `1.5.x`
line.

## What is the new behavior?
Both `package.json` ranges move to `^1.5.2`. Upstream fully reverted [PR
#788](stenciljs/output-targets#788) in
[`1.5.2`](https://github.com/stenciljs/output-targets/blob/main/packages/react/CHANGELOG.md),
so the generator emits `Components.${tag}` again and the runtime
restores `Partial<C>`. Regenerating
`packages/react/src/components/components.ts` against the `1.5.2`
generator and running prettier produces a file byte-identical to the one
committed under `1.5.0`, so the published shape is unchanged.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

The original break, the upstream conversation, and the rationale for
staying on the `1.5.x` line (rather than taking the new "errors on truly
required props" behavior) are all in the [PR #788
thread](stenciljs/output-targets#788).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footers, Headers, NavBars: API Proposal Configure bar-buttons declaratively Make footerBar API same as headerBar

3 participants