{{ message }}
Log formats and general improvements#47
Merged
Merged
Conversation
Comment on lines
+70
to
+71
There was a problem hiding this comment.
To avoid breaking changes (unless you don't mind), maybe it's worth making this default to None and if that's the case then save the output in the current, existing format?
Owner
Author
There was a problem hiding this comment.
Hmmm, good point. I'm not so concerned about breaking what was already a hard to parse log file. But perhaps it's worth adding a "text" option as the default that logs it as plain text, without the ansi stuff. Some might be more familiar with that.
initstring
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will try to help those working with tooling output programmatically.
It gets rid of the old
printcfunction and replaces it withfmt_output. This consumes findings as python dictionaries, giving us flexibility in how we deal with the data.It behaves the same in terms of printing to the screen. However, when a log file is specified it can write the individual items to it either in CSV or JSON.
Still to do:
Ideas from: #46
UPDATE:
I'm taking the time to address some other things in this PR, too: