{{ message }}
Repository navigation
IMX-3049: Fix domain check reading DNS results from the wrong place - #2
Open
scorpiofighter wants to merge 1 commit into
Open
scorpiofighter wants to merge 1 commit into
scorpiofighter wants to merge 1 commit into
Conversation
m-tse
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

improvmx domain check <domain>printedMISSINGfor MX, SPF and the overall result on every domain, even ones that are perfectly set up. It read those three values from the top of the API's reply, but they have always been nested one level down underrecords— so they always came back empty, and empty means "missing". Only--jsonwas right, because it prints the reply as-is without reading it.Before and after, on a domain that is correctly configured:
A domain that genuinely isn't set up still prints
MISSING, so this is reading the reply rather than assuming everything is fine.This is the display fix on its own. The command stays on the v3 endpoint and nothing else about it changes, so it can ship straight away. Moving the command to v4 is #1, which builds on this.
Merge order: 1 of 2 — merge before #1.
Changes
cmd/domain.go— read MX, SPF and the overall result from insiderecords.Testing
{"success": true, "records": {…}}) through the new reading code: a configured domain printsOK, an unconfigured one still printsMISSING.go buildandgo vetare clean.OKforrelai.co.zawhere it used to printMISSING. Both endpoint versions build therecordssection with the same server-side code, so that same result applies here.No automated tests — this repo has none.