Preserve indexed methods after Seq concat by puneetdixit200 · Pull Request #2191 · immutable-js/immutable-js · GitHub
Skip to content

Preserve indexed methods after Seq concat - #2191

Open
puneetdixit200 wants to merge 1 commit into
immutable-js:mainfrom
puneetdixit200:fix-indexed-concat-zip
Open

puneetdixit200 wants to merge 1 commit into
immutable-js:mainfrom
puneetdixit200:fix-indexed-concat-zip

Conversation

@puneetdixit200

Copy link
Copy Markdown

Summary:

  • preserve keyed/indexed/set sequence prototypes when concat creates a multi-collection concat sequence
  • keep the existing flattened concat iteration behavior shared across concat sequence variants
  • add a regression test that Seq.Indexed(...).concat(...).zip(...) remains available

Tests:

  • npm_config_cache=/tmp/immutable-npm-cache npx jest __tests__/concat.ts __tests__/zip.ts --runInBand
  • npm_config_cache=/tmp/immutable-npm-cache npm run test:unit -- --runInBand
  • npm_config_cache=/tmp/immutable-npm-cache npm run lint
  • npm_config_cache=/tmp/immutable-npm-cache npm run type-check
  • npm_config_cache=/tmp/immutable-npm-cache npm run build
  • git diff --check

Fixes #2161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seq.Indexed.concat doesn't return Seq.Indexed with multiple collections

1 participant