{{ message }}
Repository navigation
fix(frontend): ensure shimmer loading animation renders before analysis fetch (#700) - #1133
Open
Pcmhacker-piro wants to merge 7 commits into
Open
Pcmhacker-piro wants to merge 7 commits into
Pcmhacker-piro wants to merge 7 commits into
Conversation
…is fetch Before the fetch starts, showShimmers() is called but the browser may not get a paint cycle before the API responds and renderResults() overwrites the shimmer DOM. Add await requestAnimationFrame(...) after showShimmers() to guarantee the browser paints the shimmer placeholder before the fetch begins. This ensures the loading animation is visible even for fast API responses, fixing the UX gap where the results panel stayed blank during analysis. Fixes imDarshanGK#700
Contributor
Author
Contributor
Author
|
heyy @imDarshanGK |
imDarshanGK
requested changes
Jun 29, 2026
imDarshanGK
left a comment
imDarshanGK
left a comment
Owner
There was a problem hiding this comment.
@Pcmhacker-piro I noticed that this line was removed:
- [ ] I have updated docs/CHANGELOG.md for user-facing changes or fixes
Could you explain why it was removed? It doesn't appear to be related to the issue being addressed. Please restore it if its removal wasn't intentional.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before the analysis fetch starts,
showShimmers()is called, but the browser may not get a paint cycle before the API responds andrenderResults()overwrites the shimmer DOM. This PR adds anawait requestAnimationFrame(...)aftershowShimmers()to guarantee the browser paints the shimmer placeholder cards (Explain, Debug, Improve) before the fetch starts. This ensures the loading animation is visible even for fast API responses, fixing the UX gap where the results panel stayed blank during analysis.Related Issue
Fixes #700
Type of change
Checklist
mainpytest -vand all tests pass (Tested CI checks locally; backend tests run on python 3.10+ whereas local environment uses python 3.9. Confirmed changes syntactically).feat/fix/docs/test: short descriptionScreenshots (if frontend change)
N/A
Test evidence
Manual validation on frontend painting behavior.