{{ message }}
Repository navigation
docs: align double-checked-locking README with actual Inventory implementation - #3623
Open
1wu-davy-2 wants to merge 1 commit into
Open
1wu-davy-2 wants to merge 1 commit into
1wu-davy-2 wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b2aaa4a: docs: align double-checked-locking README with actual Inventory implementation
Files Processed (1)
- double-checked-locking/README.md (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
double-checked-locking/README.md [43-45]
readability: "Clarify terminology for the two-phase check"
-
double-checked-locking/README.md [57-59]
maintainability: "Unprotected first check may lead to data races"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
README previously described non-existent
HolderThreadSafeandHeavyclasses; updated to match the realInventory+ReentrantLockimplementation.The "Programmatic Example" section now documents the actual double-checked locking logic in
Inventory.addItem(), where the inventory size is checked once before acquiring the lock and once again inside the locked section.Checklist
double-checked-locking/README.md)Inventory.javaHolderThreadSafeorHeavyAssisted by AI tools for initial analysis; all changes manually verified and tested.