{{ message }}
Repository navigation
Conversation
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (12)
- ddba2f6: Adding Details for microkernel-architecture
- 6b1a0d8: Adding Plugin
- 6d7d86a: Reformatted as per style guide
- 29f5c0d: Reformatted as per style guide
- 24387f9: Adding Unit Tests
- b1dea43: Adding CLI and main app
- a9b0455: Adding Plugins
- 812b14f: Adding Core Plugin Functions
- d03adea: Adding Core Functions
- a16a161: Merge branch 'iluwatar:master' into #1086-microkernel-architecture-pattern
- 29d82bb: Merge branch 'iluwatar:master' into master
- e48fdf3: #1086: Init commit adding module
Files Processed (28)
- microkernel-architecture/README.md (1 hunk)
- microkernel-architecture/etc/microkernel-architecture.png (0 hunks)
- microkernel-architecture/etc/microkernel-architecture.puml (1 hunk)
- microkernel-architecture/etc/microkernel-flow.png (0 hunks)
- microkernel-architecture/etc/microkernel-flow.puml (1 hunk)
- microkernel-architecture/pom.xml (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/App.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/cli/CommandLineInterface.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/AbstractLifecyclePlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/AbstractOnDemandPlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/MicroKernel.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/Plugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/ipc/IpcRouter.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/ipc/Message.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/JavaLanguagePlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/NeonThemePlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/PluginCatalog.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/RemoveSpacesPlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/UppercasePlugin.java (1 hunk)
- microkernel-architecture/src/main/java/com/iluwatar/microkernel/registry/PluginRegistry.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/AppTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/cli/CommandLineInterfaceTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/core/MicroKernelTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/ipc/IpcRouterTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/plugins/PluginCatalogTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/plugins/PluginImplementationsTest.java (1 hunk)
- microkernel-architecture/src/test/java/com/iluwatar/microkernel/registry/PluginRegistryTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (3)
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/ipc/IpcRouter.java [51-80]
best_practice: "Logger naming consistency"
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/JavaLanguagePlugin.java [49-54]
best_practice: "Consistency: logger naming for JavaLanguagePlugin"
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/UppercasePlugin.java [46-52]
best_practice: "Consistency: logger naming for UppercasePlugin"
Skipped Comments (3)
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/MicroKernel.java [0-0]
best_practice: "Logging consistency across core module"
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/core/AbstractLifecyclePlugin.java [0-0]
best_practice: "Lifecycle hooks idempotency"
-
microkernel-architecture/src/main/java/com/iluwatar/microkernel/plugins/RemoveSpacesPlugin.java [32-36]
best_practice: "Logger usage consistency in RemoveSpacesPlugin"
KishalayP
marked this pull request as ready for review
September 27, 2026 19:39
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3610 +/- ##
============================================
+ Coverage 84.06% 84.31% +0.24%
- Complexity 4353 4449 +96
============================================
Files 1133 1146 +13
Lines 15400 15643 +243
Branches 739 759 +20
============================================
+ Hits 12946 13189 +243
+ Misses 2158 2156 -2
- Partials 296 298 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 46ce10a: Adding Unit Tests
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#1086: Implementation of the Microkernel Architecture Pattern as described in the issue
What does this PR do?
This PR introduces a complete, interactive implementation of the Microkernel Architecture Pattern (also known as the Plug-in architecture) to the repository. It uses a text editor simulation to demonstrate how to effectively separate a minimal core system from optional, specialized processing features.
This implementation demonstrates: