{{ message }}
Repository navigation
feat: add log deployments and changes pattern (#2696) - #3606
Open
arnabnandy7 wants to merge 2 commits into
Open
arnabnandy7 wants to merge 2 commits into
arnabnandy7 wants to merge 2 commits into
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
Signed-off-by: Arnab Nandy arnab_nandy7@yahoo.com
Files Processed (13)
- .github/workflows/log-deployments-and-changes.yml (1 hunk)
- microservices-log-deployments-and-changes/README.md (1 hunk)
- microservices-log-deployments-and-changes/pom.xml (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/App.java (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/CentralLogStore.java (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/ChangeEvent.java (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/ChangeType.java (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/DeploymentPipeline.java (1 hunk)
- microservices-log-deployments-and-changes/src/main/java/com/iluwatar/logdeploymentsandchanges/LogMonitor.java (1 hunk)
- microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/CentralLogStoreTest.java (1 hunk)
- microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/DeploymentPipelineTest.java (1 hunk)
- microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/LogMonitorTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (3)
-
microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/DeploymentPipelineTest.java [98-98]
possible bug: "Invalid List API usage in test"
-
microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/LogMonitorTest.java [78-78]
possible bug: "Invalid List API usage in test"
-
microservices-log-deployments-and-changes/pom.xml [50-50]
best_practice: "Missing JUnit API dependency"
Skipped Comments (0)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3606 +/- ##
============================================
+ Coverage 83.79% 83.82% +0.02%
- Complexity 4277 4297 +20
============================================
Files 1121 1127 +6
Lines 15144 15204 +60
Branches 723 724 +1
============================================
+ Hits 12690 12744 +54
- Misses 2159 2164 +5
- Partials 295 296 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
Signed-off-by: Arnab Nandy arnab_nandy7@yahoo.com
Files Processed (1)
- microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/AppTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/AppTest.java [61-61]
maintainability: "Deterministic actor for timeline expectations"
-
microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/AppTest.java [56-56]
best_practice: "Robustness of timeline detection"
-
microservices-log-deployments-and-changes/src/test/java/com/iluwatar/logdeploymentsandchanges/AppTest.java [89-93]
maintainability: "Fragile assertion of warning messages"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the Microservices Log Deployments and Changes pattern with centralized event history, automatic deployment and change outcome logging, a console timeline, and configurable alert filtering.
Includes documentation, a class diagram, and a manual CI workflow demonstrating simulated deployments and changes. Follows the existing log-aggregation module structure.
Validated with Java 21: all 5 tests pass, and Spotless formatting checks pass.
Fixes #2696