{{ message }}
Repository navigation
Revise 1.1 - #3605
Open
AnakinYen0329 wants to merge 12 commits into
Open
Revise 1.1#3605AnakinYen0329 wants to merge 12 commits into
AnakinYen0329 wants to merge 12 commits into
Conversation
…ema validation failures
Pin presubmit/ai-reviewer to v0.2.5 and remove the incompatible LLM_MODEL setting. Include the prepared Traditional Chinese abstract-document localization.
Resolve the presubmit workflow conflict while keeping the pinned ai-reviewer v0.2.5 configuration.
Update zh-TW localization wording from formal second-person pronouns to casual wording.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (11)
Update zh-TW localization wording from formal second-person pronouns to casual wording.
- a16cba6: Merge origin/master into master
Resolve the presubmit workflow conflict while keeping the pinned ai-reviewer v0.2.5 configuration.
- eba6b92: fix: stabilize presubmit AI reviewer workflow
Pin presubmit/ai-reviewer to v0.2.5 and remove the incompatible LLM_MODEL setting. Include the prepared Traditional Chinese abstract-document localization.
- ddc6c19: ci: pin presubmit/ai-reviewer to v0.2.5 to avoid breaking changes from @latest
- fea0ddb: ci: remove LLM_MODEL from presubmit workflow to avoid ai-reviewer schema validation failures
- f0de978: translation
- 52508ab: 修改1.1
- 0ba0213: Merge branch 'iluwatar:master' into master
- 91b7826: Add Singleton pattern example
- e5f82f8: 修改完成
Files Processed (30)
- .github/workflows/presubmit.yml (1 hunk)
- localization/zh-TW/abstract-document/README.md (1 hunk)
- localization/zh-TW/abstract-factory/README.md (1 hunk)
- localization/zh-TW/actor-model/README.md (1 hunk)
- localization/zh-TW/acyclic-visitor/README.md (1 hunk)
- localization/zh-TW/acyclic-visitor/etc/acyclic-visitor.png (0 hunks)
- localization/zh-TW/adapter/README.md (1 hunk)
- localization/zh-TW/adapter/etc/adapter.urm.png (0 hunks)
- localization/zh-TW/aggregator-microservices/README.md (1 hunk)
- localization/zh-TW/aggregator-microservices/etc/aggregator-service.png (0 hunks)
- localization/zh-TW/ambassador/README.md (1 hunk)
- localization/zh-TW/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/zh-TW/anti-corruption-layer/README.md (1 hunk)
- localization/zh-TW/anti-corruption-layer/etc/anti-corruption-layer-sequence-diagram.png (0 hunks)
- localization/zh-TW/api-gateway/README.md (1 hunk)
- localization/zh-TW/api-gateway/etc/api-gateway.png (0 hunks)
- localization/zh-TW/arrange-act-assert/README.md (1 hunk)
- localization/zh-TW/async-method-invocation/README.md (1 hunk)
- localization/zh-TW/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/zh-TW/backends-for-frontends/README.md (1 hunk)
- localization/zh-TW/backpressure/README.md (1 hunk)
- localization/zh-TW/balking/README.md (1 hunk)
- localization/zh-TW/balking/etc/balking.png (0 hunks)
- localization/zh-TW/bloc/README.md (1 hunk)
- localization/zh-TW/bridge/README.md (1 hunk)
- localization/zh-TW/bridge/etc/bridge.urm.png (0 hunks)
- localization/zh-TW/builder/README.md (1 hunk)
- localization/zh-TW/builder/etc/builder.urm.png (0 hunks)
- localization/zh-TW/business-delegate/README.md (1 hunk)
- localization/zh-TW/business-delegate/etc/business-delegate.urm.png (0 hunks)
Actionable Comments (1)
-
.github/workflows/presubmit.yml [24-24]
possible issue: "Potential YAML indentation issue in presubmit workflow."
Skipped Comments (1)
-
localization/zh-TW/actor-model/README.md [142-143]
readability: "Localization readability and consistency in Actor Model README."
| exit 1 | ||
| fi | ||
| - uses: presubmit/ai-reviewer@latest | ||
| - uses: presubmit/ai-reviewer@v0.2.5 |
There was a problem hiding this comment.
Consider YAML indentation and structure for the new presubmit step. The new action uses presubmit/ai-reviewer@v0.2.5; ensure the 'env:' mapping is correctly indented under the step (two-space indentation under the 'uses' line). Mis-indentation could break the workflow.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 1a4d224: docs: add five zh-TW pattern translations
Files Processed (30)
- .github/workflows/presubmit.yml (1 hunk)
- localization/zh-TW/abstract-document/README.md (1 hunk)
- localization/zh-TW/abstract-factory/README.md (1 hunk)
- localization/zh-TW/actor-model/README.md (1 hunk)
- localization/zh-TW/acyclic-visitor/README.md (1 hunk)
- localization/zh-TW/acyclic-visitor/etc/acyclic-visitor.png (0 hunks)
- localization/zh-TW/adapter/README.md (1 hunk)
- localization/zh-TW/adapter/etc/adapter.urm.png (0 hunks)
- localization/zh-TW/aggregator-microservices/README.md (1 hunk)
- localization/zh-TW/aggregator-microservices/etc/aggregator-service.png (0 hunks)
- localization/zh-TW/ambassador/README.md (1 hunk)
- localization/zh-TW/ambassador/etc/ambassador.urm.png (0 hunks)
- localization/zh-TW/anti-corruption-layer/README.md (1 hunk)
- localization/zh-TW/anti-corruption-layer/etc/anti-corruption-layer-sequence-diagram.png (0 hunks)
- localization/zh-TW/api-gateway/README.md (1 hunk)
- localization/zh-TW/api-gateway/etc/api-gateway.png (0 hunks)
- localization/zh-TW/arrange-act-assert/README.md (1 hunk)
- localization/zh-TW/async-method-invocation/README.md (1 hunk)
- localization/zh-TW/async-method-invocation/etc/async-method-invocation.png (0 hunks)
- localization/zh-TW/backends-for-frontends/README.md (1 hunk)
- localization/zh-TW/backpressure/README.md (1 hunk)
- localization/zh-TW/balking/README.md (1 hunk)
- localization/zh-TW/balking/etc/balking.png (0 hunks)
- localization/zh-TW/bloc/README.md (1 hunk)
- localization/zh-TW/bridge/README.md (1 hunk)
- localization/zh-TW/bridge/etc/bridge.urm.png (0 hunks)
- localization/zh-TW/builder/README.md (1 hunk)
- localization/zh-TW/builder/etc/builder.urm.png (0 hunks)
- localization/zh-TW/business-delegate/README.md (1 hunk)
- localization/zh-TW/business-delegate/etc/business-delegate.urm.png (0 hunks)
Actionable Comments (0)
Skipped Comments (6)
-
.github/workflows/presubmit.yml [24-27]
best_practice: "Fix YAML indentation for CI step"
-
.github/workflows/presubmit.yml [28-29]
best_practice: "CI file end-of-file cleanliness"
-
localization/zh-TW/adapter/README.md [1-50]
readability: "Consistency in localized READMEs"
-
localization/zh-TW/anti-corruption-layer/README.md [1-60]
readability: "Code block validation in ACL README"
-
localization/zh-TW/api-gateway/README.md [1-15]
readability: "Ensure downstream types exist"
-
localization/zh-TW/backpressure/README.md [1-20]
readability: "Dependency note for backpressure example"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expanded zh-TW localization with new pattern READMEs and assets, replacing formal pronouns with casual tone in existing abstracts.
Changes
Added new zh-TW Callback README
Updated localization assets
Replaced formal pronouns with casual tone in existing pattern abstracts
Added supporting images and diagrams
Related Issue
Fixes #[issue-number] (if applicable)
Type of Change
Bug fix
New localization
Breaking change