{{ message }}
docs: correct stale R-comparison-tests TODO row (R not in CI)#535
Merged
Conversation
…c-deps mention The "R comparison tests spawn separate Rscript per test (slow CI)" row's premise is false: no CI workflow installs R (no setup-r / r-lib/actions / fixest / r-base in .github/workflows/), so every R-parity test skips in CI behind a per-file availability gate. The originally-cited test_methodology_twfe.py already session-caches its R fits via scope="session" fixtures. Rewrite the row to document the correction (the only residual is a local-dev-only micro-optimization in continuous_did / callaway, which re-spawn library() per call with no session cache) and drop the already-shipped "doc-deps integrity CI" (#519) from the dangling Tier D parenthetical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
igerber
force-pushed
the
perf/rscript-consolidation
branch
from
bbb7cf5 to
6290ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rscriptper test (slow CI)". The premise is false — no CI workflow installs R (nosetup-r/r-lib/actions/fixest/r-baseanywhere in.github/workflows/), so every R-parity test skips in CI behind a per-file availability gate (fixest_available,_check_r_contdid(),require_r/r_available). ConsolidatingRscriptspawns therefore yields zero CI speedup.tests/test_methodology_twfe.py) already session-caches its R fits via@pytest.fixture(scope="session")(r_twfe_results/r_twfe_results_with_covariate).continuous_did.py/callaway.pyre-spawnlibrary(...)per call with no session cache). Retained as a low-value local-dev note rather than silently dropped, so it isn't re-raised as a CI-speed item.Methodology references
TODO.md). No estimator, identification, weighting, or variance/SE behavior is touched.Validation
grepconfirms no R in.github/workflows/; the twfe session-scoped fixtures, thecontinuous_did/callawaycall sites, and the removed chore: add CI integrity check for docs/doc-deps.yaml #519 doc-deps row/test (tests/test_doc_deps_integrity.pyexists) were each confirmed.gpt-5.5, full standard,--force-fresh): ✅ clean — no P0/P1/P2; one P3-informational note confirming the reframing is correct.Security / privacy
🤖 Generated with Claude Code