{{ message }}
Create new comment on synchronize/reopened (not update canonical)#418
Merged
Conversation
PR #416 expanded the workflow trigger from `pull_request: [opened]` to `[opened, reopened, synchronize]` so PRs would auto-re-review on push, but didn't update the post-comment step. That step's `isRerun` check only treated `issue_comment` and `pull_request_review_comment` as reruns (create new comment); every other event — including `pull_request: synchronize` — fell through to the update-canonical branch. Effect: pushing a rebase or new commits to a PR re-runs the review and silently overwrites the prior review comment via the update-comment API. GitHub does not expose issue-comment edit history, so the previous review content is gone once the update lands. This is a real data-loss footgun beyond the obvious UX regression (no notification on update, review history not preserved). Fix: treat any non-opened pull_request event as a rerun. const isRerun = context.eventName === "issue_comment" || context.eventName === "pull_request_review_comment" || (context.eventName === "pull_request" && context.payload.action !== "opened"); Only `pull_request.opened` updates the canonical comment in place (creating it if absent). Everything else — push, reopen, manual /ai-review, or review-comment trigger — creates a new comment so prior review content is preserved and each push generates a notification. Tests: 2 new assertions in `TestWorkflowCommentPosting` that pin the isRerun expression's non-opened branch + the comment-event branches, so this can't silently regress again. 172 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
R1 review on PR #418 caught the sibling-surface gap: the post-comment step's JS `isRerun` was updated to treat synchronize/reopened as reruns, but the prompt-build step's YAML `IS_RERUN` env was not. Effect: on synchronize/reopened, a new comment was posted (correct) but the prompt omitted the <previous-ai-review-output> block and re-review framing (incorrect), so the model could not focus on whether prior findings were addressed. Fix mirrors the JS predicate into the YAML predicate: IS_RERUN: ${{ github.event_name == 'issue_comment' || github.event_name == 'pull_request_review_comment' || (github.event_name == 'pull_request' && github.event.action != 'opened') }} Also expands TestWorkflowCommentPosting to pin BOTH gates and the parity between them, so future edits to one cannot silently diverge from the other. New tests: - test_yaml_isrerun_includes_non_opened_pull_request - test_yaml_isrerun_still_includes_comment_events - test_both_gates_enumerate_same_triggers 175 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #416 expanded the workflow's `pull_request` trigger from `[opened]` to
`[opened, reopened, synchronize]` so PRs auto-re-review on push, but didn't update
the post-comment step. The step's `isRerun` check only treated `issue_comment` and
`pull_request_review_comment` as reruns (create new comment); every other event
fell through to update-canonical.
Effect: pushing a rebase or new commits to a PR re-runs the review and silently
overwrites the prior review comment via GitHub's update-comment API. GitHub does
not expose issue-comment edit history, so the previous review content is gone once
the update lands.
This fix treats any non-`opened` `pull_request` event as a rerun:
```js
const isRerun =
context.eventName === "issue_comment" ||
context.eventName === "pull_request_review_comment" ||
(context.eventName === "pull_request" &&
context.payload.action !== "opened");
```
Only `pull_request.opened` updates the canonical comment in place. Push, reopen,
manual `/ai-review`, and review-comment triggers all create a new comment so prior
review content is preserved and each push generates a notification.
Methodology references
Validation
non-opened branch and comment-event branches so this can't silently regress.
Backward-compatibility
comments continue to update on initial-open events.
run prevents collisions with future reruns).
Security / privacy
🤖 Generated with Claude Code