feat: sheet expand and collapse behaviour and impl by itssharmasandeep · Pull Request #1374 · hypertrace/hypertrace-ui · GitHub
Skip to content

feat: sheet expand and collapse behaviour and impl#1374

Closed
itssharmasandeep wants to merge 1 commit into
mainfrom
sheet-collapse-expand
Closed

feat: sheet expand and collapse behaviour and impl#1374
itssharmasandeep wants to merge 1 commit into
mainfrom
sheet-collapse-expand

Conversation

@itssharmasandeep

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov

codecov Bot commented Jan 14, 2022

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Unit Test Results

    4 files  ±0  275 suites  ±0   19m 17s ⏱️ - 1m 1s
978 tests ±0  977 ✔️  - 1  0 💤 ±0  1 ❌ +1 
986 runs  ±0  985 ✔️  - 1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 5f3be7b. ± Comparison against base commit cc99f03.

@anandtiwary

Copy link
Copy Markdown
Contributor

@itssharmasandeep #1382 fixes the bug you mentioned. Please check and let me know if this works.

Let's not add animation. This one looks good as it is.

@itssharmasandeep

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants