{{ message }}
[FlatPostgresCollection] Implement bulkCreateOrReplaceReturnOlder + drop + Bugfix for delete(key) always returning true#286
Merged
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
puneet-traceable,
skjindal93 and
suresh-prakash
as code owners
Test Results 120 files + 7 120 suites +7 38s ⏱️ ±0s Results for commit 8a18b2d. ± Comparison against base commit 2fe1f90. This pull request removes 27 and adds 45 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| @Override | ||
| public void drop() { | ||
| throw new UnsupportedOperationException(WRITE_NOT_SUPPORTED); | ||
| String dropTableSQL = String.format("DROP TABLE IF EXISTS %s", tableIdentifier); |
There was a problem hiding this comment.
do we really need this? For postgres we haven't been creating table using this route, deletion should probably not happen through this route.
Contributor
Author
There was a problem hiding this comment.
I added this method for completeness sake, since we have this for Mongo. If any direct clients want to use it, they'd have an option.
There was a problem hiding this comment.
I am ok with it being there. Might be useful just for tests.
The way I am thinking about it is: if drop is exposed here, then corresponding createTable should also happen via this route. A simple create is also fine. But any other DDL on the table will be very hard. So my personal recommendation is to have all of this happen outside or we build comprehensive ddl support.
Contributor
Author
There was a problem hiding this comment.
As discussed, table management is not supported via this interface, so I have removed this impl.
puneet-traceable
previously approved these changes
Apr 9, 2026
Contributor
puneet-traceable
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains three changes:
FlatPostgresCollection#bulkUpserthad a bug where it would replace missing columns in the query withnull. It now has proper merge semantics.Collection#bulkCreateOrReplaceReturnOlderand implement it forFlatPostgresCollection. This is similar toFlatPostgresCollection#bulkUpsertReturnOlderbut with replace (instead of merge) semantics.FlatPostgresCollection#delete(key)would always returntrueeven if no rows were deleted - This was divergent with Mongo's behaviour. So this has been fixed.ImplementThis is now rolled back.FlatPostgresCollection#drop.Testing
Added integration tests + compatibility tests.
Checklist: