fix(ci): resolve five pre-existing main-branch CI failures by hyperpolymath · Pull Request #44 · hyperpolymath/affinescript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hypatia-scan.yml
5 changes: 5 additions & 0 deletions .github/workflows/instant-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ permissions:
jobs:
dispatch:
runs-on: ubuntu-latest
# Skip the dispatch job entirely when the FARM_DISPATCH_TOKEN secret is
# not configured (e.g. on forks, or before the secret is provisioned).
# Without this gate the action errors with "Parameter token or opts.auth
# is required" and the whole workflow fails on every main push.
if: ${{ vars.FARM_DISPATCH_ENABLED == 'true' }}
steps:
- name: Trigger Propagation
uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v3
Expand Down
27 changes: 23 additions & 4 deletions .github/workflows/rsr-antipattern.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,34 @@ jobs:

- name: Check for TypeScript
run: |
# Exclude bindings/deno/ - those are Deno FFI files using Deno.dlopen, not plain TypeScript
# Exclude .d.ts files - those are TypeScript type declarations for ReScript FFI
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) | grep -v node_modules | grep -v 'bindings/deno' | grep -v '\.d\.ts$' || true)
# Exclusions, in order of specificity. Each is "essential glue" —
# the platform requires TypeScript and a ReScript replacement is
# not viable.
#
# - bindings/deno/ : Deno FFI files using Deno.dlopen.
# - *.d.ts : TypeScript declarations for ReScript FFI.
# - affinescript-deno-test/ : Deno-native test runner (Deno is
# TS-native; the test driver imports Deno.test which has no
# ReScript binding).
# - editors/vscode/ : VS Code extension. The extension API is
# exclusively TypeScript; no ReScript path exists.
# - faces/ : vendored snapshots of upstream face
# implementations; the antipattern policy applies to upstream,
# not to a vendored copy in this repo.
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
| grep -v node_modules \
| grep -v 'bindings/deno' \
| grep -v '\.d\.ts$' \
| grep -v '^\./affinescript-deno-test/' \
| grep -v '^\./editors/vscode/' \
| grep -v '^\./faces/' \
|| true)
if [ -n "$TS_FILES" ]; then
echo "❌ TypeScript files detected - use ReScript instead"
echo "$TS_FILES"
exit 1
fi
echo "✅ No TypeScript files (Deno FFI bindings excluded)"
echo "✅ No TypeScript files (essential-glue exclusions applied)"

- name: Check for Go
run: |
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/workflow-linter.yml
1 change: 0 additions & 1 deletion faces/rattlescript/affinescript/dune-project

This file was deleted.

Loading