{{ message }}
style: replace single-character lifetime names with descriptive names - #4173
Merged
Conversation
cratelyn
approved these changes
Aug 28, 2026
cratelyn
left a comment
cratelyn
left a comment
Member
There was a problem hiding this comment.
thank you! i have one small nit about one of the lifetime names used here.
Co-authored-by: katelyn martin <git@katelyn.world>
dox4
force-pushed
the
style/descriptive-lifetime-names
branch
from
August 28, 2026 17:47
fd72939 to
36e2d78
Compare
Contributor
Author
dswij
approved these changes
Aug 29, 2026
snowyukitty
added a commit
to snowyukitty/hyper
that referenced
this pull request
Sep 3, 2026
Upstream hyperium#4173 restyled the `chunks_vectored` overrides this branch removes, so all four conflicts were the same shape. Kept the `VectoredBuf` trait and its `chunks_vectored_prefix`, and adopted hyperium#4173's convention by renaming the `'t` lifetime to `'data` in the code this branch adds.
snowyukitty
added a commit
to snowyukitty/hyper
that referenced
this pull request
Sep 3, 2026
Upstream hyperium#4173 restyled the `chunks_vectored` overrides this branch removes, so all four conflicts were the same shape. Kept the `VectoredBuf` trait and its `chunks_vectored_prefix`, and adopted hyperium#4173's convention by renaming the `'t` lifetime to `'data` in the code this branch adds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
single_char_lifetime_namesallow lint from the strict clippy config and replaces all single-character lifetime names with descriptive names.Part of #4071.