{{ message }}
Optimized Hyperf\Coordinator\Timer::tick() to run the callback inside Hyperf\Coroutine\wait() so it executes in a properly managed coroutine context.#7761
Merged
Conversation
Run the timer callback inside Hyperf\Coroutine\wait() so it executes in a properly managed coroutine context, and move the $round initialization outside the try block.
huangdijia
force-pushed
the
fix-timer-wait-3.1
branch
from
12a0b9d to
e83a40f
Compare
limingxinleo
changed the title
Hyperf\Coordinator\Timer::tick() to run the callback inside Hyperf\Coroutine\wait() so it executes in a properly managed coroutine context.
limingxinleo
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
Timercallback was invoked directly inside the timer coroutine. Wrapping it withHyperf\Coroutine\wait()ensures the callback runs in a properly managed coroutine context.What
$closure($isClosing)withwait(fn() => $closure($isClosing))inTimer::tick().$round = 0initialization out of thetryblock.Hyperf\Coroutine\wait.