Added casts `AsCollection` for `hyperf/database`. by adhikjoshi · Pull Request #7607 · hyperf/hyperf · GitHub
Skip to content

Added casts AsCollection for hyperf/database.#7607

Merged
limingxinleo merged 12 commits into
hyperf:masterfrom
adhikjoshi:add-casts
Feb 1, 2026
Merged

Added casts AsCollection for hyperf/database.#7607
limingxinleo merged 12 commits into
hyperf:masterfrom
adhikjoshi:add-casts

Conversation

@adhikjoshi

@adhikjoshi adhikjoshi commented Nov 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding casts to make it compatible with Hypervel and other frameworks

@huangdijia huangdijia requested a review from Copilot November 9, 2025 13:33
Copilot AI reviewed Nov 9, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces three new casting classes for the Hyperf database model layer, providing enhanced attribute casting functionality for models.

Key Changes:

  • Adds a Json class with customizable JSON encoding/decoding capabilities
  • Adds an Attribute class for defining custom attribute accessors and mutators with caching options
  • Adds an AsCollection class for casting JSON attributes to Collection instances with optional item mapping

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/database/src/Model/Casts/Json.php Provides static methods for JSON encoding/decoding with support for custom encoders/decoders
src/database/src/Model/Casts/Attribute.php Implements an attribute accessor/mutator builder with fluent API and caching control
src/database/src/Model/Casts/AsCollection.php Implements a Castable interface for casting JSON data to Collection instances with optional item transformation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/database/src/Model/Casts/Attribute.php Outdated
Comment thread src/database/src/Model/Casts/Attribute.php Outdated
Comment thread src/database/src/Model/Casts/Attribute.php Outdated
Comment thread src/database/src/Model/Casts/AsCollection.php Outdated
Comment thread src/database/src/Model/Casts/Json.php Outdated
Comment thread src/database/src/Model/Casts/Json.php
adhikjoshi and others added 5 commits November 11, 2025 09:55
@adhikjoshi
Update src/database/src/Model/Casts/Attribute.php
9086791 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adhikjoshi
Update src/database/src/Model/Casts/AsCollection.php
fcbb95a 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adhikjoshi
Update src/database/src/Model/Casts/Json.php
28e4037 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adhikjoshi
Update Attribute.php
79d20a2
@adhikjoshi
Update Json.php
7d98d07
@adhikjoshi

adhikjoshi commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

@huangdijia all issues resolved, do review and feel free to merge.

1 similar comment
@adhikjoshi

adhikjoshi commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

@huangdijia all issues resolved, do review and feel free to merge.

huangdijia
huangdijia previously approved these changes Nov 19, 2025
View reviewed changes
@huangdijia

huangdijia commented Nov 19, 2025

Copy link
Copy Markdown
Member

@huangdijia all issues resolved, do review and feel free to merge.

Increase unit testing

@albertcht albertcht mentioned this pull request Nov 24, 2025
Closed
@adhikjoshi

adhikjoshi commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@huangdijia there's error on tests,

- Root composer.json requires smarty/smarty ^3.1, found smarty/smarty[v3.1.11, ..., v3.1.48] but these were not loaded, because they are affected by security advisories. To ignore the advisories, add ("PKSA-5rsx-p2fk-h2gr") to the audit "ignore" config. To turn the feature off entirely, you can set "block-insecure" to false in your "audit" config.

Let's fix smarty/smarty version and i can continue

@huangdijia

huangdijia commented Nov 24, 2025

Copy link
Copy Markdown
Member

@huangdijia there's error on tests,

- Root composer.json requires smarty/smarty ^3.1, found smarty/smarty[v3.1.11, ..., v3.1.48] but these were not loaded, because they are affected by security advisories. To ignore the advisories, add ("PKSA-5rsx-p2fk-h2gr") to the audit "ignore" config. To turn the feature off entirely, you can set "block-insecure" to false in your "audit" config.

Let's fix smarty/smarty version and i can continue

Rebase on master

@adhikjoshi

adhikjoshi commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@huangdijia there's error on tests,

- Root composer.json requires smarty/smarty ^3.1, found smarty/smarty[v3.1.11, ..., v3.1.48] but these were not loaded, because they are affected by security advisories. To ignore the advisories, add ("PKSA-5rsx-p2fk-h2gr") to the audit "ignore" config. To turn the feature off entirely, you can set "block-insecure" to false in your "audit" config.

Let's fix smarty/smarty version and i can continue

Rebase on master

Done, + added PHP CS fixer changes

@limingxinleo

limingxinleo commented Dec 4, 2025

Copy link
Copy Markdown
Member

把单元测试加上，看不懂要怎么用

@adhikjoshi

adhikjoshi commented Jan 10, 2026

Copy link
Copy Markdown
Contributor Author

@limingxinleo limingxinleo changed the title added casts Added casts AsCollection for hyperf/database. Feb 1, 2026
@limingxinleo limingxinleo merged commit 76c560d into hyperf:master Feb 1, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@limingxinleo limingxinleo limingxinleo approved these changes
@huangdijia huangdijia huangdijia left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adhikjoshi @huangdijia @limingxinleo