Description

This PR fixes an issue related to size rule validation (e.g., min or max) in the hyperf/validation package when running on PHP 8.4.

Hows to Reproduce

class ExampleRequest extends FormRequest
{
    public function rules(): array
    {
        return [
            'username' => ['min:6', 'max:255'],
        ];
    }
}

Problem

In PHP 8.4, the default value of the escape parameter in the str_getcsv function is deprecated.
Relying on the default (\) can produce invalid CSV parsing behavior or non-RFC 4180-compliant output, particularly when the escape character is not explicitly defined.

PHP 8.4 Changelog
Relying on the default value of escape is now deprecated.
When escape is set to anything other than an empty string (""), it can result in CSV that is not compliant with RFC 4180 or unable to survive a roundtrip through the PHP CSV functions.
The default value will change in a future version of PHP, no earlier than PHP 9.0.

Solution

🛠️ Code Adjustment
Updated the usage of str_getcsv to explicitly define the escape parameter as an empty string:

// Before
return str_getcsv($parameter);

// After
return str_getcsv($parameter, ',', '"', '');

References

https://www.php.net/manual/en/function.str-getcsv.php
https://php.watch/versions/8.4/csv-functions-escape-parameter