{{ message }}
Add close button to all toast notifications#886
Open
Rhoahndur wants to merge 1 commit intohumanlayer:mainfrom
Open
Add close button to all toast notifications#886Rhoahndur wants to merge 1 commit intohumanlayer:mainfrom
Rhoahndur wants to merge 1 commit intohumanlayer:mainfrom
Conversation
… the global Sonner Toaster config so all toasts have a dismissible X button by default.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 712f31a in 25 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/internal/CodeLayerToaster.tsx:21
- Draft comment:
✔️ Adding 'closeButton: true' globally ensures all toasts include a manual dismiss button. Consider verifying that the Sonner library provides proper ARIA labels for accessibility on the close button, or adding them if needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_MMJzZ1YP6EgWLqZ3
You can customize 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
Toast notifications couldn't be dismissed manually - users had to wait for them to auto-dismiss.
What user-facing changes did I ship?
All toast notifications now have a close button (X) in the top-left corner.
How I implemented it
Added closeButton: true to the global Sonner Toaster config in CodeLayerToaster.tsx.
How to verify it
Description for the changelog
Added close button to all toast notifications for easier dismissal.
Important
Add close button to toast notifications in
CodeLayerToasterfor manual dismissal.closeButton: truetotoastOptionsinCodeLayerToasterto enable manual dismissal of toast notifications.This description was created by
for 712f31a. You can customize this summary. It will automatically update as commits are pushed.