{{ message }}
[do not merge] testing rotary embedding + torch.compile#9321
Closed
yiyixuxu wants to merge 4 commits into
Closed
Conversation
sayakpaul
reviewed
Aug 31, 2024
| @@ -716,21 +718,24 @@ def __call__( | |||
| # broadcast to batch dimension in a way that's compatible with ONNX/Core ML | |||
| timestep = t.expand(latents.shape[0]).to(latents.dtype) | |||
Member
There was a problem hiding this comment.
This would be another candidate for syncs because we're iterating over a tensor here. See this internal link for more details.
|
I'd call |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

this is script I use to generate trace
benchmark test
I'm using this testing scripts, some numbers below
( I don't think putting arrange on device improved anything, but there is a difference from 0.30.1-patch so should look into that)
main before the lastest commit (with graph break warning)
main with latest commit (#9307)
in the PR (do arange on gpu)
0.30.1-patch (using the original flux rotary embeds, before this PR #9074)
testing script