Cleanup pass for flaky Slow Tests for Stable diffusion by DN6 · Pull Request #4415 · huggingface/diffusers · GitHub
Skip to content

Cleanup pass for flaky Slow Tests for Stable diffusion - #4415

Merged
DN6 merged 7 commits into
mainfrom
cleanup-slowtests-stable-diffusion
Aug 1, 2023
Merged

DN6 merged 7 commits into
mainfrom
cleanup-slowtests-stable-diffusion

Conversation

@DN6

@DN6 DN6 commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator

What does this PR do?

Address precision issues with some flaky slow tests in the stable diffusion module.

  1. Set pipe.unet.set_default_attn_processor() to use default attention on failing tests.
  2. Update expected slices where necessary. And use float32 numpy arrrays when comparing slices.
  3. Lower precision on panorama pipeline after inspecting output arrays.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6
DN6 requested a review from patrickvonplaten August 1, 2023 09:52
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

@patrickvonplaten patrickvonplaten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@DN6
DN6 merged commit 6f4355f into main Aug 1, 2023
@kashif
kashif deleted the cleanup-slowtests-stable-diffusion branch September 13, 2023 13:40
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
)

* update expected slice so img2img compile tests pass

* use default attn processor

* use default attn processor and update expected slice value to pass test

* use default attn processor

* set default attn processor and update expected slice

* set default attn processor and change precision for check

* set unet to use default attn processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants