{{ message }}
Repository navigation
Accept pooled_prompt_embeds in the SDXL Controlnet pipeline. Fixes an error if prompt_embeds are passed. - #4309
Merged
Merged
Conversation
… error if prompt_embeds are passed.
Contributor
|
Cool! |
patrickvonplaten
approved these changes
Jul 27, 2023
bghira
approved these changes
Jul 28, 2023
sayakpaul
approved these changes
Jul 29, 2023
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Excellent. Do you think it might be worth to also add a test for this?
Contributor
Author
|
@sayakpaul Thanks. I've added a test, by copying the test from |
Member
|
Thanks for your amazing contribution. |
Contributor
Author
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
… error if prompt_embeds are passed. (huggingface#4309) * Accept pooled_prompt_embeds in the SDXL Controlnet pipeline. Fixes an error if prompt_embeds are passed. * Add a test for pooled prompt embeds
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
… error if prompt_embeds are passed. (huggingface#4309) * Accept pooled_prompt_embeds in the SDXL Controlnet pipeline. Fixes an error if prompt_embeds are passed. * Add a test for pooled prompt embeds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The SDXL Controlnet pipeline would fail to run if
prompt_embedswas passed (instead ofprompt), because the implementation wouldn't create the pooled embeds (and would fail later with aNoneType does not have repeat methoderror).This copies the code from the other SDXL pipelines.
Thanks!
@sayakpaul @patrickvonplaten