[tests] remove `test_pipelines_common.py` by sayakpaul · Pull Request #14669 · huggingface/diffusers · GitHub
Skip to content

[tests] remove test_pipelines_common.py - #14669

Merged
sayakpaul merged 24 commits into
mainfrom
remove-test-pipelines-common
Oct 6, 2026
Merged

sayakpaul merged 24 commits into
mainfrom
remove-test-pipelines-common

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Sep 1, 2026 •

Copy link
Copy Markdown
Member
  • Move FluxIPAdapterTesterMixin to the IP Adapter testing utils since it's shared by more than Flux.
  • Migrate old imports in the test suites of DeepFloyd IF, etc. to use new ones.
  • Migrate the Stable Diffusion Adapter test suite to use new mixins.
  • Remove test_pipelines_common.py.

@github-actions github-actions Bot added tests size/L PR with diff > 200 LOC labels Sep 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to other ideas but I chose to xfail these tests and not introduce anything really new to our shared tester mixins.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py passed on GPU — view logs.

Comment thread tests/pipelines/testing_utils/memory.py Outdated
Comment thread tests/pipelines/kandinsky/test_kandinsky_prior.py Outdated
@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference was cancelled on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py passed on GPU — view logs.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

@github-actions

github-actions Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference passed on GPU — view logs.

@github-actions github-actions Bot added the CI label Sep 1, 2026
pytest -n 1 --max-worker-restart=0 --dist=loadfile \
--make-reports=tests_torch_minimum_version_cuda \
tests/models/test_modeling_common.py \
tests/pipelines/test_pipelines_common.py \

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exists.

Comment on lines -17 to +19
- "tests/pipelines/test_pipelines_common.py"
- "tests/pipelines/testing_utils/**.py"
- "tests/models/test_modeling_common.py"
- "tests/models/testing_utils/**.py"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have parity in our CI when test changes happen.

pytest -n 1 --max-worker-restart=0 --dist=loadfile \
--make-reports=tests_torch_minimum_cuda \
tests/models/test_modeling_common.py \
tests/pipelines/test_pipelines_common.py \

@sayakpaul sayakpaul Sep 3, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer exists.

)


class AdapterPipelineTesterConfig(BasePipelineTesterConfig):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining test suite being refactored.

@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/ passed on GPU — view logs.

Comment thread tests/pipelines/testing_utils/ip_adapter.py Outdated
Comment thread tests/pipelines/flux/testing_utils.py
@sayakpaul
sayakpaul requested a review from DN6 September 11, 2026 05:28
@hf-security-analysis

hf-security-analysis Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

@sayakpaul sayakpaul added this to the Release 0.41.0 milestone Sep 30, 2026
Comment thread tests/pipelines/testing_utils/common.py Outdated
Comment thread utils/extract_tests_from_mixin.py Outdated
@sayakpaul
sayakpaul merged commit 7717798 into main Oct 6, 2026
24 of 40 checks passed
@sayakpaul
sayakpaul deleted the remove-test-pipelines-common branch October 6, 2026 06:13
mingyi456 added a commit to mingyi456/diffusers that referenced this pull request Oct 6, 2026
* 'main' of https://github.com/huggingface/diffusers:
  [tests] remove `test_pipelines_common.py` (huggingface#14669)
  [chore] remove force_upcast from autoencoder flux2 (huggingface#14946)
  Configure fixed sampling sigmas on QwenImage21Pipeline (huggingface#14950)
  [tests] refactor the pipeline-level attention processor tests (huggingface#14701)
  [modular] Echo team joy future academy jd echo by @Gelercatty (huggingface#14941)
  Fix: Deprecating Siglip2ImageProcessorFast (huggingface#14781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants