{{ message }}
Repository navigation
refactor deepfloyd if img2img pipeline tests to the new mixin structure - #14596
Merged
sayakpaul merged 3 commits intoAug 26, 2026
Merged
Conversation
sayakpaul
reviewed
Aug 25, 2026
Comment on lines
+151
to
+152
Member
There was a problem hiding this comment.
I think if we load it using eval() it should be fine? Could we check?
Contributor
Author
There was a problem hiding this comment.
You're right. The old base test ran the fresh components in train mode, so the tiny-random-t5 dropout was the "non-determinism"; the new get_pipeline() puts both sides in eval. Replicated the save/load flow on CPU fp32: eval both sides gives max_diff 1.7e-5, the train-mode first pipe gives 0.94. Dropped the override here and in #14580.
Contributor
github-actions
Bot
added
size/M
sayakpaul
approved these changes
Aug 26, 2026
4 of 6 tasks
sayakpaul
approved these changes
Aug 26, 2026
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the DeepFloyd IF img2img pipeline tests to the new mixin structure from #14113, same shape as the text-to-image port: an
IFImg2ImgPipelineTesterConfigplusTestIFImg2ImgPipeline(PipelineTesterMixin)andTestIFImg2ImgPipelineMemory(PipelineOffloadTesterMixin), slow class ported to pytest, dummy components inlined from the shared package mixin, and a fresh CPU slice intest_inference.The same verified choices as #14580 apply:
@skip_mpskept (all-NaN output on mps),latentsdropped fromoptional_input_params, the customtest_save_load_optional_componentsported (prompt pre-encoded), the obsoletesave_load_localoverride dropped, and the float16 1e-1 tolerance kept. The oldtest_float16_inferenceoverride maps to the framework'stest_half_precision_inference_no_nan, which needs no tolerance. Follows #14580.Before submitting
Who can review?
@sayakpaul