{{ message }}
Repository navigation
docs: fix 14 typos in docs, comments and docstrings - #14541
Merged
Merged
Conversation
Prose, comments and docstrings only. No executable line changed.
docs/:
- optimization/memory.md: maxmium -> maximum; heigh -> height (in the
channels_last layout tuple, which read "(batch size, heigh, width,
channels)")
- api/pipelines/bria_fibo.md: proffesional -> professional
- api/pipelines/wan.md: involed -> involved
src/ comments and docstrings:
- guiders/magnitude_aware_guidance.py: supression -> suppression
- models/attention.py: spliting -> splitting
- models/attention_dispatch.py: abritrary -> arbitrary (x2)
- models/transformers/transformer_ltx2.py: timstamps -> timestamps (x2)
- pipelines/ltx2/pipeline_ltx2{,_image2video}.py: corrct -> correct
- pipelines/deprecated/unidiffuser/modeling_uvit.py: tbe -> the
- pipelines/visualcloze/pipeline_visualcloze_{combined,generation}.py:
"whe they are lists" -> "when they are lists" in a user-facing
ValueError message
Deliberately not touched:
- pipeline_kandinsky*.py "promt"/"scren" live inside prompt_template,
which is fed to the text encoder verbatim. Changing them would change
generation output.
- ANE (Apple Neural Engine), MoT (Mixture-of-Transformers): initialisms.
- "racoon": appears in prompt examples whose reference images were
generated with that exact prompt.
- "Shuting Wang": a paper author's name.
github-actions
Bot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14345 (merged), taking up @stevhliu's "feel free to include others here as well!" —
that PR is closed now, so these are in a separate one.
14 spelling fixes across docs, comments, and docstrings. No behavior change except that two of them
are in user-visible
ValueErrortext.What's fixed
docs/.../bria_fibo.mdproffesional→professionaldocs/.../memory.mdmaxmium→maximum;heigh→height(in thechannels_lasttensor-shape explanation, where the wrong word makes the shape wrong)docs/.../wan.mdguiders/magnitude_aware_guidance.pysupression→suppression(docstring)models/attention.pyspliting→splitting(comment)models/attention_dispatch.pyabritrary→arbitrary×2 (comment)models/transformers/transformer_ltx2.pytimstamps→timestamps×2 (comments)pipelines/deprecated/unidiffuser/modeling_uvit.pytbe→the(docstringReturns:)pipelines/ltx2/pipeline_ltx2*.pycorrct→correct×2 (TODO comments)pipelines/visualcloze/pipeline_visualcloze_{combined,generation}.pywhe they→when they×2 — user-visible, insideraise ValueError(...)incheck_inputsDeliberately excluded
Verified and left alone, so they don't look like oversights:
promt/screninpipeline_kandinsky*.py— these sit insideprompt_templatestrings thatare fed verbatim to the text encoder. Fixing the spelling would change generated output, which is a
behavior change, not a typo fix.
ANE,MoT— initialisms (Apple Neural Engine, Mixture-of-Transformers).racoon— appears in prompt examples whose reference images were generated with that exact(misspelled) prompt, so the example and the image would stop matching.
Shuting Wang— a paper author's name.Validation
Rebased onto
main@4e0466f3e; the original commit cherry-picked cleanly, so all 14 sites stillexist upstream.
git diff --stat: 12 files, +14/-14.Self-review (per CONTRIBUTING)
Ran the
.ai/skills/self-reviewrubric against.ai/review-rules.md:# Copied from(AGENTS.md): checked explicitly, because the twovisualclozefiles fix thesame error string and that is the shape a copy-link usually takes. Both changed lines are inside
check_inputs(generation.py:404,combined.py:170), and neither method carries a# Copied fromheader — the markers in those files sit on_get_t5_prompt_embeds,_get_clip_prompt_embeds,_encode_vae_image,get_timesteps,_pack_latents. So editing bothby hand is correct here rather than fixing an upstream source and running
make fix-copies.# per reviewstyle comments.docs/updates are implied beyond the two doc typos already included.
I could not run
python utils/check_copies.pylocally —utils/is outside my sparse checkout — sothe copy-link check above is the manual equivalent. CI's
check_repository_consistencywill confirm.🤖 Written with Claude Code. Every one of the 14 sites was read in
context, and the four excluded classes were each checked rather than assumed.