{{ message }}
Repository navigation
[kernels] download kernels when users request for it. - #14298
Merged
Merged
Conversation
github-actions
Bot
added
documentation
DN6
reviewed
Jul 28, 2026
| from kernels import get_kernel | ||
|
|
||
| ops = get_kernel("Isotr0py/ggml") | ||
| ops = get_kernel("Isotr0py/ggml", trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS) |
Collaborator
There was a problem hiding this comment.
Wouldn't this break for anyone using kernels<=0.14?
https://github.com/huggingface/diffusers/pull/14298/changes#diff-249c332f10872ba150d634947de12055f99d9db5c3dbf2bef092ccba775f39bdR97
Also trust_remote_code should resolve based on whether downloading remote code is remotely disabled as well.
Suggested change
| ops = get_kernel("Isotr0py/ggml", trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS) | |
| ops = get_kernel("Isotr0py/ggml", trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS and not DIFFUSERS_DISABLE_REMOTE_CODE) |
| from kernels import get_kernel | ||
|
|
||
| ops = get_kernel(_HF_KERNEL_REPO, version=_HF_KERNEL_VERSION, trust_remote_code=True).ops | ||
| ops = get_kernel(_HF_KERNEL_REPO, version=_HF_KERNEL_VERSION, trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS).ops |
Collaborator
There was a problem hiding this comment.
Should also respect global remote code download flag
Suggested change
| ops = get_kernel(_HF_KERNEL_REPO, version=_HF_KERNEL_VERSION, trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS).ops | |
| ops = get_kernel(_HF_KERNEL_REPO, version=_HF_KERNEL_VERSION, trust_remote_code=DIFFUSERS_TRUST_REMOTE_KERNELS and not DIFFUSERS_DISABLE_REMOTE_CODE).ops |
Comment on lines
33
to
37
| can_use_cuda_kernels = ( | ||
| os.getenv("DIFFUSERS_GGUF_CUDA_KERNELS", "false").lower() in ["1", "true", "yes"] | ||
| and torch.cuda.is_available() | ||
| and torch.cuda.get_device_capability()[0] >= 7 | ||
| ) |
Collaborator
There was a problem hiding this comment.
Can be done in a follow up. But I think we can remove/deprecate this flag and use DIFFUSER_TRUST_REMOTE_KERNELS as the standard flag for these kinds of operations.
Member
Author
|
@DN6 addressed. |
DN6
reviewed
Aug 3, 2026
Collaborator
There was a problem hiding this comment.
Think we can just raise a warning here and run without the kernel. It's backwards breaking if we raise an error.
DN6
approved these changes
Aug 3, 2026
DN6
pushed a commit
that referenced
this pull request
Aug 6, 2026
* download kernels when users request for it. * address review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were downloading and loading kernels for
ggufandnunchaku-litewithout asking from users. This PR fixes that.