{{ message }}
Repository navigation
[attention backends] use dedicated wrappers from fa3 for cp. - #13165
Merged
Merged
Conversation
vasqu
approved these changes
Feb 19, 2026
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
LGTM, trusting you that this works as it seems we don't have tests?
Comments are mostly for my interest / nits
| repo_id="kernels-community/flash-attn3", function_attr="flash_attn_func", revision="fake-ops-return-probs" | ||
| repo_id="kernels-community/flash-attn3", | ||
| function_attr="flash_attn_func", | ||
| revision="fake-ops-return-probs", |
There was a problem hiding this comment.
Ah didnt notice it before, we don't have it merged into main yet?
| out, | ||
| softmax_lse, | ||
| None, | ||
| None, # cu_seqlens_q, cu_seqlens_k |
There was a problem hiding this comment.
Just fmi, there is no fa varlen cp yet? I think meta had a version at some point
Member
Author
There was a problem hiding this comment.
We handle varlen separately + varlens aren't that common in diffusion use cases.
Member
Author
DN6
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Great pointer here #12812 (comment) from @vasqu.