{{ message }}
Repository navigation
Fix: update type hints for Tuple parameters across multiple files to support variable-length tuples - #12544
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type hint inconsistencies across multiple files by updating Tuple type annotations to use variable-length syntax (Tuple[type, ...]) where parameters accept tuples of arbitrary length. This addresses issues similar to #4806 where fixed-length tuple annotations were incorrectly used for parameters that should accept variable-length tuples.
Key changes:
- Updated type hints from
Tuple[str]toTuple[str, ...]for block type parameters - Updated type hints from
Tuple[int]toTuple[int, ...]for channel configuration parameters - Fixed one incorrect annotation from
Tuple[str]tostrfor a non-tuple parameter
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
…support variable-length tuples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Many classes exhibit the issues present in #4806, but these have not been fixed or reported. This PR attempts to resolve a batch of similar issues.
Fixes all issues like #4806
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.