Performance Improve for Qwen Image Edit by naykun · Pull Request #12190 · huggingface/diffusers · GitHub
Skip to content

Performance Improve for Qwen Image Edit - #12190

Merged
asomoza merged 2 commits into
huggingface:mainfrom
naykun:main
Aug 19, 2025
Merged

asomoza merged 2 commits into
huggingface:mainfrom
naykun:main

Conversation

@naykun

@naykun naykun commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.

Please kindly give it a review.
cc @yiyixuxu @a-r-r-o-w @sayakpaul

- update condition reshaping logic to improve editing performance
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

@linoytsaban

Copy link
Copy Markdown
Collaborator

thanks!

since _auto_resize is removed from the preprocessing, should it be removed altogether, here as well?

- remove _auto_resize
@naykun

naykun commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

thanks!

since _auto_resize is removed from the preprocessing, should it be removed altogether, here as well?

Sure, resolved in latest commit.

@asomoza asomoza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@asomoza
asomoza merged commit cc48b93 into huggingface:main Aug 19, 2025
sayakpaul pushed a commit that referenced this pull request Aug 20, 2025
* fix(qwen-image-edit):
- update condition reshaping logic to improve editing performance

* fix(qwen-image-edit):
- remove _auto_resize
@gluttony-10

Copy link
Copy Markdown

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.

Please kindly give it a review. cc @yiyixuxu @a-r-r-o-w @sayakpaul

This is an incorrect update. Picture consistency is lost again.

@naykun

naykun commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

We observe that conditioning resolution strongly influences the alignment of source and target images. This PR introduces a unified resize logic, resulting in significantly enhanced editing performance.
Please kindly give it a review. cc @yiyixuxu @a-r-r-o-w @sayakpaul

This is an incorrect update. Picture consistency is lost again.

Could you please share your img, prompt and your experiment setting?

@gluttony-10

Copy link
Copy Markdown
f7dec461761a500b08b9889e8efab936 #12188 Its right. f9ba41754c98140122b036c2a154457a #12190

@naykun

naykun commented Aug 20, 2025 •

Copy link
Copy Markdown
Contributor Author

@gluttony-10 I noticed the two cases use different prompts, and the seeds are not the same—this could lead to different outputs. Also, are you using prompt enhancement? If possible, please share your input image, and I’ll run a local test for comparison.

@gluttony-10

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants