{{ message }}
Repository navigation
Fix Wan AccVideo/CausVid fuse_lora - #11856
Merged
Merged
Conversation
Collaborator
|
Both commits fix the issue of not allowing |
sayakpaul
approved these changes
Jul 4, 2025
| if key.endswith((".diff", ".diff_b")) and "norm" in key: | ||
| # NOTE: we don't support this because norm layer diff keys are just zeroed values. We can support it | ||
| # in future if needed and they are not zeroed. | ||
| original_state_dict.pop(key) |
Member
There was a problem hiding this comment.
Not a blocker but might just quickly zero if it's all zeros:
Contributor
Author
There was a problem hiding this comment.
From the original codebases where this comes from, I don't think these keys can be anything but zero and yesterday's investigation revealed the same. Probably best to not do anything else here IMO
| original_state_dict.pop(key) | ||
| logger.debug(f"Removing {key} key from the state dict as it is a norm diff key. This is unsupported.") | ||
|
|
||
| if "time_projection" in key and not has_time_projection_weight: |
Contributor
Author
|
For some reason the tests fail with the latest main merged. It's again one of those errors that when I try to reproduce locally, just passes. If I run the test alone, it passes. If I run all the tests, the test fails. 😢 |
Member
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 5, 2025
* fix * actually, better fix * empty commit; trigger tests again * mark wanvace test as flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both AccVideo and CausVid work on my end with fuse_lora.
@apolinario Could you give this a try and see if it resolves the issue you faced?