{{ message }}
Repository navigation
[lora] fix: lora unloading behvaiour - #11822
Merged
Merged
Conversation
BenjaminBossan
approved these changes
Jun 27, 2025
BenjaminBossan
left a comment
BenjaminBossan
left a comment
Member
There was a problem hiding this comment.
Thanks for this bugfix, LGTM.
Regarding the name, I believe both are a bit imprecise, as the method both adds and runs asserts. Not a big deal, just my 2c.
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 5, 2025
* fix: lora unloading behvaiour * fix * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For the text encoder, we set:
diffusers/src/diffusers/loaders/lora_base.py
Line 194 in cdaf84a
We should also do the same for the denoiser but doesn't:
diffusers/src/diffusers/loaders/peft.py
Lines 680 to 688 in cdaf84a
This PR fixes that.
The problem without this would surface when running the test this PR adds (i.e., add an adapter, unload it, and then try to add it again).
I have also taken the liberty to rename a function to
add_adapters_to_pipeline()which I think is more appropriate.