{{ message }}
Repository navigation
Warn once when resuming a shuffled dataset - #8844
Open
jinchuntan wants to merge 1 commit into
Open
jinchuntan wants to merge 1 commit into
jinchuntan wants to merge 1 commit into
Conversation
Keep the shuffle-buffer warning without repeating it for every checkpoint restore or dataset instance. Check repeated and initial checkpoint restores through the public iterable API. Fixes huggingface#7444 Assisted-by: Codex
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated checkpoint restores can print the same shuffle-buffer warning thousands of times. This shows it once per process, including when several datasets are restored. Fixes #7444.
Added four cases covering repeated restores and initial checkpoints, with checks on the returned rows. The iterable suite has 655 passes and 39 skips. Six multiprocessing tests also fail on unchanged main in this environment (blocked Unix sockets and a worker timeout). Lint and formatting pass.