Just prevent `TypeError: Cannot read property 'constructor' of undefined` by jasonxia23 · Pull Request #235 · hueitan/angular-validation · GitHub
Skip to content

Just prevent TypeError: Cannot read property 'constructor' of undefined#235

Open
jasonxia23 wants to merge 2 commits into
hueitan:masterfrom
jasonxia23:master
Open

Just prevent TypeError: Cannot read property 'constructor' of undefined#235
jasonxia23 wants to merge 2 commits into
hueitan:masterfrom
jasonxia23:master

Conversation

@jasonxia23

Copy link
Copy Markdown

Just prevent TypeError: Cannot read property 'constructor' of undefined

@coveralls

coveralls commented Sep 18, 2016

Copy link
Copy Markdown

@liorcode

liorcode commented Sep 25, 2016

Copy link
Copy Markdown
Contributor

please update both the sources and create the dist and minified dist files using the build task and squash your commits.

But I actually think the solution should be in the checkValidation function itself.. I think it should always return either error or success, never undefined. This is my proposal: #241

@hueitan

hueitan commented Oct 14, 2016

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants