feat: paginated gh pull request query builder by Anonycoders · Pull Request #2185 · hub4j/github-api · GitHub
Skip to content

feat: paginated gh pull request query builder#2185

Merged
bitwiseman merged 1 commit into
hub4j:mainfrom
Anonycoders:paginated-gh-query-builder
Feb 10, 2026
Merged

feat: paginated gh pull request query builder#2185
bitwiseman merged 1 commit into
hub4j:mainfrom
Anonycoders:paginated-gh-query-builder

Conversation

@Anonycoders

@Anonycoders Anonycoders commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Description

https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov

codecov Bot commented Jan 25, 2026

Copy link
Copy Markdown

@bitwiseman bitwiseman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't exactly test that the page sizing is working. You need a query with greater than the page size items and then check the that the returned first page has the expected size.

Still, this is unlikely to be an issue. We'll call it good.

@bitwiseman bitwiseman merged commit 9152b37 into hub4j:main Feb 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more methods to QueryBuilder

2 participants