fix: remove usage of a deprecated constant. by ketan · Pull Request #2138 · hub4j/github-api · GitHub
Skip to content

fix: remove usage of a deprecated constant.#2138

Merged
bitwiseman merged 1 commit into
hub4j:mainfrom
ketan:fix-2137
Sep 2, 2025
Merged

fix: remove usage of a deprecated constant.#2138
bitwiseman merged 1 commit into
hub4j:mainfrom
ketan:fix-2137

Conversation

@ketan

@ketan ketan commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes #2137 by replacing the usage of a deprecated constant (PropertyNamingStrategy#SNAKE_CASE). This constant was dropped in jackson-databind v2.20.0.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov

codecov Bot commented Sep 1, 2025

Copy link
Copy Markdown

@bitwiseman bitwiseman merged commit a2fe6ca into hub4j:main Sep 2, 2025
13 checks passed
bitwiseman added a commit that referenced this pull request Sep 2, 2025
This change requires Jackson  or later.  This change is technically breaking but 5+ years old.

FasterXML/jackson-databind@9f97baa

Fixes #2137
@ketan ketan deleted the fix-2137 branch September 3, 2025 06:40
@gsmet

gsmet commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

@bitwiseman 👋 I think we will need a release with this change very soon as it starts to get in the way.

We updated to 2.20 in Quarkus for this month release and I'm pretty sure all the other frameworks will do the same.

@pvillard31

Copy link
Copy Markdown
Contributor

Same here, would be great to have a release including this fix. Just mentioning it here after closing the issue #2140. Thanks a lot!

@bitwiseman

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime errors when using jackson 2.20.0

4 participants