Removed unused checked exceptions by rnveach · Pull Request #2036 · hub4j/github-api · GitHub
Skip to content

Removed unused checked exceptions#2036

Merged
bitwiseman merged 3 commits into
hub4j:mainfrom
rnveach:unused_exceptions
Feb 25, 2025
Merged

Removed unused checked exceptions#2036
bitwiseman merged 3 commits into
hub4j:mainfrom
rnveach:unused_exceptions

Conversation

@rnveach

@rnveach rnveach commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Description

Removes exceptions not thrown by the methods.

@codecov

codecov Bot commented Feb 17, 2025

Copy link
Copy Markdown

@bitwiseman

Copy link
Copy Markdown
Member

Removing exceptions... I thought this was a binary breaking change, but the API checks didn't fail for this change...

I need to look at this further.

@rnveach

rnveach commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

Do you want me to try and split this between main and test?

Also, I would think this would still be acceptable to do to non-public methods in main as users can't write code to link to them outside of reflection anyways.

Finally, can you also provide more information on this project's stance on binary breaking change? Is this project fully against them, or this requires a special release?

Also what checks is used to catch these? I see the POM has japicmp-maven-plugin.

@rnveach

rnveach commented Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

@bitwiseman bitwiseman self-requested a review February 24, 2025 18:17

@bitwiseman bitwiseman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating with latest changes. Assuming japicmp reports all clear, we'll take this.

Thanks!

@bitwiseman bitwiseman changed the title removed exceptions not thrown Removed unused checked exceptions Feb 25, 2025
@bitwiseman bitwiseman merged commit 8343b6b into hub4j:main Feb 25, 2025
@rnveach rnveach deleted the unused_exceptions branch February 26, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants