Fixed redirection on proxy when changeOrigin enable by sequoiar · Pull Request #396 · http-party/node-http-proxy · GitHub
Skip to content

Fixed redirection on proxy when changeOrigin enable#396

Closed
sequoiar wants to merge 2 commits into
http-party:masterfrom
sequoiar:master
Closed

Fixed redirection on proxy when changeOrigin enable#396
sequoiar wants to merge 2 commits into
http-party:masterfrom
sequoiar:master

Conversation

@sequoiar

Copy link
Copy Markdown

Redirection has four cases:

  1. redirect to the same target with changeOrigin
  2. redirect to the same target without changeOrigin
  3. redirect to the different target with changeOrigin
  4. redirect to the different target without changeOrigin

the existing code can handle case 2, the fix is for case 1. case 3 and case 4 need to handle proxy response event to add proxy entry by user logic.

@subnetmarco

Copy link
Copy Markdown
Contributor

@tonyarkles

Copy link
Copy Markdown

I was just affected by this. Would definitely help my current project to have this merged.

@indexzero

Copy link
Copy Markdown
Member

We're almost done with a major rewrite that has been under way for several months. Check it out on the caronte branch. We haven't decided what to do with pull-request maintenance before that.

We will likely publish 0.10.99 with most open pull-requests before publishings 1.0.0. cc/ @yawnt

@tonyarkles

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants