feat: display warning log message when it can not parse config by is2ei · Pull Request #893 · htmlhint/HTMLHint · GitHub
Skip to content

feat: display warning log message when it can not parse config - #893

Merged
coliff merged 1 commit into
htmlhint:masterfrom
is2ei:warn-invalid-json-conf
Sep 6, 2022
Merged

feat: display warning log message when it can not parse config#893
coliff merged 1 commit into
htmlhint:masterfrom
is2ei:warn-invalid-json-conf

Conversation

@is2ei

@is2ei is2ei commented Jan 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #662

Short description of what this resolves:
This PR changes it to display a warning log message when it can not parse config.

Proposed changes:
Display warning log message

Screen Shot 2022-01-31 at 1 50 24

@is2ei
is2ei requested a review from thedaviddias as a code owner January 30, 2022 16:07
@github-actions github-actions Bot added cli Relates to HTMLHint's command-line interface test labels Jan 30, 2022
@is2ei

is2ei commented Jan 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@is2ei
is2ei force-pushed the warn-invalid-json-conf branch from 52ca8c9 to 653dd66 Compare January 30, 2022 16:48
@codecov

codecov Bot commented Jan 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #893 (f16d78c) into master (5a17fdd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files           2        2           
  Lines        1627     1627           
  Branches      291      291           
=======================================
  Hits         1573     1573           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bef2a...f16d78c. Read the comment docs.

@is2ei
is2ei force-pushed the warn-invalid-json-conf branch from 653dd66 to f39ef04 Compare January 30, 2022 16:50
@is2ei

is2ei commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

Tests are fixed. Could you review it?

@is2ei

is2ei commented Mar 22, 2022

Copy link
Copy Markdown
Contributor Author

@thedaviddias
Hi, would this change be acceptable? If not, I'll close this PR.

@stale

stale Bot commented May 25, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the bot:stale Issue marked as stale because there was no activity label May 25, 2022
@stale stale Bot closed this Jun 11, 2022
@coliff coliff reopened this Jun 11, 2022
@stale stale Bot removed the bot:stale Issue marked as stale because there was no activity label Jun 11, 2022
@coliff

coliff commented Jun 11, 2022

Copy link
Copy Markdown
Member

@thedaviddias you approved this so can it be merged ?

@thedaviddias thedaviddias added the keep-unstale The issue will not be marked as stale by the stale-bot label Jul 22, 2022
@thedaviddias

thedaviddias commented Jul 22, 2022

Copy link
Copy Markdown
Member

@thedaviddias you approved this so can it be merged ?

Yes, it can. @is2ei Can you just fix the conflict?

@is2ei
is2ei force-pushed the warn-invalid-json-conf branch from f39ef04 to 9169f02 Compare July 23, 2022 10:14
@is2ei
is2ei force-pushed the warn-invalid-json-conf branch from 9169f02 to f16d78c Compare July 23, 2022 10:17
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Jul 23, 2022
@is2ei

is2ei commented Jul 23, 2022

Copy link
Copy Markdown
Contributor Author

@coliff
coliff merged commit bad68d9 into htmlhint:master Sep 6, 2022
@coliff coliff mentioned this pull request May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thedaviddias thedaviddias thedaviddias approved these changes

Assignees

No one assigned

Labels

cli Relates to HTMLHint's command-line interface dependencies Pull requests that update a dependency file keep-unstale The issue will not be marked as stale by the stale-bot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.htmlhintrc silently ignored if not valid JSON

3 participants

@is2ei @coliff @thedaviddias