Bump Flake8 to fix CI for Python 3.7 by hugovk · Pull Request #554 · html5lib/html5lib-python · GitHub
Skip to content

Bump Flake8 to fix CI for Python 3.7#554

Merged
ambv merged 2 commits into
html5lib:masterfrom
hugovk:fix-ci
Mar 1, 2023
Merged

Bump Flake8 to fix CI for Python 3.7#554
ambv merged 2 commits into
html5lib:masterfrom
hugovk:fix-ci

Conversation

@hugovk

@hugovk hugovk commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

The Python 3.7 CI job has started failing:

    self._load_entrypoint_plugins()
  File "/home/runner/work/html5lib-python/html5lib-python/.tox/py/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'
ERROR: InvocationError for command /home/runner/work/html5lib-python/html5lib-python/.tox/py/bin/flake8 . (exited with code 1)

This is because importlib_metadata 5.0 removes some deprecations, and it's a dependency of Flake8. But new Flake8 works, so let's update:

Also fix the new Flake8 findings:

./html5lib/_inputstream.py:327:27: E275 missing whitespace after keyword
./html5lib/serializer.py:225:15: E275 missing whitespace after keyword
./html5lib/serializer.py:232:15: E275 missing whitespace after keyword
./html5lib/treewalkers/etree.py:40:19: E275 missing whitespace after keyword
./html5lib/treebuilders/etree.py:111:19: E275 missing whitespace after keyword
./html5lib/treebuilders/etree.py:204:19: E275 missing whitespace after keyword
./html5lib/tests/test_serializer.py:77:19: E275 missing whitespace after keyword

@ambv ambv merged commit 3ecbda6 into html5lib:master Mar 1, 2023
@hugovk hugovk deleted the fix-ci branch March 1, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants