Migrate bracketed IP addresses in ZHA config entry by puddly · Pull Request #95917 · home-assistant/core · GitHub
Skip to content

Migrate bracketed IP addresses in ZHA config entry - #95917

Merged
balloob merged 4 commits into
home-assistant:devfrom
puddly:puddly/zha-bracketed-ip-fix
Jul 6, 2023
Merged

Migrate bracketed IP addresses in ZHA config entry#95917
balloob merged 4 commits into
home-assistant:devfrom
puddly:puddly/zha-bracketed-ip-fix

Conversation

@puddly

@puddly puddly commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Proposed change

CPython 3.11.4 exposed a URI parsing bug in previous versions (python/cpython#103848) that allowed for bracketed IP addresses like socket://[1.2.3.4]:5678 to erroneously be parsed correctly. This PR automatically fixes these URIs (and also removes stale migration code scheduled to be removed in 2023.7.0).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@puddly puddly added this to the 2023.7.1 milestone Jul 5, 2023
@home-assistant

home-assistant Bot commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

@puddly puddly mentioned this pull request Jul 5, 2023
Closed
Adminiuga
Adminiuga reviewed Jul 5, 2023
View reviewed changes

@Adminiuga Adminiuga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread homeassistant/components/zha/__init__.py Outdated
Adminiuga
Adminiuga approved these changes Jul 5, 2023
View reviewed changes

@Adminiuga Adminiuga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balloob
balloob merged commit ecc0917 into home-assistant:dev Jul 6, 2023
balloob pushed a commit that referenced this pull request Jul 6, 2023
@puddly @balloob
Migrate bracketed IP addresses in ZHA config entry (#95917)
6275932 
* Automatically correct IP addresses surrounded by brackets

* Simplify regex

* Move pattern inline

* Maintain old behavior of stripping whitespace
@balloob balloob mentioned this pull request Jul 6, 2023
Merged
joostlek pushed a commit to joostlek/core that referenced this pull request Jul 6, 2023
@puddly @joostlek
Migrate bracketed IP addresses in ZHA config entry (home-assistant#95917
f43d103 
)

* Automatically correct IP addresses surrounded by brackets

* Simplify regex

* Move pattern inline

* Maintain old behavior of stripping whitespace
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Adminiuga Adminiuga Adminiuga approved these changes
@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels

bugfix by-code-owner cherry-picked cla-signed has-tests integration: zha Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2023.7.1

Development

Successfully merging this pull request may close these issues.

Zigbee devices no longer working in 2023.6.2

4 participants

@puddly @Adminiuga @dmulcahey @balloob